Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace latest and nightly copies in bin/ with symlinks #33

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Replace latest and nightly copies in bin/ with symlinks #33

merged 2 commits into from
Jul 17, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Jul 6, 2020 •
edited
Loading

Related to #32 (and actually depends on that PR). Part of ethereum/solidity#9258.

It's also a PR to the master branch. Changed to gh-pages.

It takes the change a bit further by removing all copies of soljson.js from bin/ and replacing them with symlinks. This requires more changes to the update script and it's just a refactor, not a fix so I'm putting it in a separate PR #32.

@cameel cameel requested review from ekpyron and chriseth July 6, 2020 18:37
@cameel cameel self-assigned this Jul 6, 2020
@cameel
Copy link
Member Author

cameel commented Jul 6, 2020

This triggers some really weird linter warnings:

(node:6978) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:6978) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:6978) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
...

I'm not sure what they're all about but I wanted to finish for today so I'll investigate them tomorrow. Looks like putting it in a separate PR was a good idea.

@chriseth chriseth mentioned this pull request Jul 7, 2020
Merged
Base automatically changed from fix-update-script-damaging-releases-via-symlinks to master July 7, 2020 09:10
@cameel cameel force-pushed the replace-latest-and-nightly-with-symlinks branch 2 times, most recently from 5393676 to e8fe2fc Compare July 7, 2020 09:30
@cameel
Copy link
Member Author

cameel commented Jul 7, 2020

Looks like the Accessing non-existent property warnings were not introduced in this PR and they don't affect the checks anyway. It's actually a cosmetic problem that comes from shelljs which is a dependency of eslint, which in turn is a dependency of standard, which we use for linting. It has already been fixed upstream (shelljs/shelljs#991) and the warning will go away after we update our dependencies (#31).

The checks were failing because were actual linter warnings below the warnings that I missed. Now they're fixed.

@cameel cameel mentioned this pull request Jul 7, 2020
Merged
@cameel cameel changed the base branch from master to gh-pages July 7, 2020 10:09
@cameel
Copy link
Member Author

cameel commented Jul 7, 2020

Changing the target branch to gh-pages.

@cameel cameel force-pushed the replace-latest-and-nightly-with-symlinks branch 2 times, most recently from 63db362 to ddccd0b Compare July 8, 2020 17:35
@cameel cameel mentioned this pull request Jul 9, 2020
Merged
2 tasks
@cameel cameel force-pushed the replace-latest-and-nightly-with-symlinks branch from ddccd0b to c4d99f1 Compare July 13, 2020 15:17
@cameel cameel force-pushed the replace-latest-and-nightly-with-symlinks branch from c4d99f1 to f30c903 Compare July 16, 2020 23:43
@cameel cameel mentioned this pull request Jul 17, 2020
Merged
@cameel cameel force-pushed the replace-latest-and-nightly-with-symlinks branch from f30c903 to 2d4517c Compare July 17, 2020 00:48
@chriseth chriseth merged commit ec4a845 into gh-pages Jul 17, 2020
@cameel cameel deleted the replace-latest-and-nightly-with-symlinks branch July 17, 2020 15:07
@cameel cameel mentioned this pull request Feb 3, 2022
Merged
@cameel cameel mentioned this pull request Sep 8, 2022
Closed
@clonker clonker mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

@ekpyron ekpyron Awaiting requested review from ekpyron

Assignees

@cameel cameel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameel @chriseth